On Tue, May 01, 2018 at 06:46:04PM +0100, James Morse wrote: > Hi Akashi, > > On 25/04/18 07:26, AKASHI Takahiro wrote: > > Change this function from static to global so that arm64 can implement > > its own arch_kimage_file_post_load_cleanup() later using > > kexec_image_post_load_cleanup_default(). > > Do we need to call kexec_image_post_load_cleanup_default()? All it does is call > the image-type fops->cleanup(), which you don't implement in this series. > > Is this just-in-case someone adds cleanup() later and is surprised only the > arch-level helper is called? Yes, we want not to miss two possibilities: - some common clean-up code is added to kexec_image_post_load_cleanup_default() - some format(i.e. Image)-specific clean-up code is added to fops->cleanup() -Takahiro AKASHI > > > Thanks, > > James _______________________________________________ kexec mailing list kexec@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/kexec
