On 03/06/18 at 02:15pm, Michal Suchanek wrote:
> Not all architectures implement KEXEC_FILE_LOAD. However, on some
> archiectures KEXEC_FILE_LOAD is required when secure boot is enabled in
> locked-down mode. Previously users had to select the KEXEC_FILE_LOAD
> syscall with undocumented -s option. However, if they did pass the
> option kexec would fail on architectures that do not support it.
>
> So add an -a option that tries KEXEC_FILE_LOAD and when it is not
> supported tries KEXEC_LOAD.
>
> Signed-off-by: Michal Suchanek <msuchanek@xxxxxxx>
> ---
> v3: instead of changing the deafult add extra option
> v4: actually check -ENOSYS as well
> ---
> kexec/kexec.c | 52 ++++++++++++++++++++++++++++++++++++++++++++++++----
> kexec/kexec.h | 4 +++-
> 2 files changed, 51 insertions(+), 5 deletions(-)
>
> diff --git a/kexec/kexec.c b/kexec/kexec.c
> index a95cfb473d6b..5c5aee344b41 100644
> --- a/kexec/kexec.c
> +++ b/kexec/kexec.c
> @@ -1243,6 +1243,7 @@ int main(int argc, char *argv[])
> int do_unload = 0;
> int do_reuse_initrd = 0;
> int do_kexec_file_syscall = 0;
> + int do_kexec_fallback = 0;
> int do_status = 0;
> void *entry = 0;
> char *type = 0;
> @@ -1367,10 +1368,15 @@ int main(int argc, char *argv[])
> break;
> case OPT_KEXEC_FILE_SYSCALL:
> do_kexec_file_syscall = 1;
> + do_kexec_fallback = 0;
> break;
> case OPT_KEXEC_SYSCALL:
> do_kexec_file_syscall = 0;
> + do_kexec_fallback = 0;
> break;
> + case OPT_KEXEC_SYSCALL_AUTO:
> + do_kexec_file_syscall = 1;
> + do_kexec_fallback = 1;
need a break here
> case OPT_STATUS:
> do_status = 1;
> break;
> @@ -1442,16 +1448,54 @@ int main(int argc, char *argv[])
> result = k_status(kexec_flags);
> }
> if (do_unload) {
> - if (do_kexec_file_syscall)
> + if (do_kexec_file_syscall) {
> result = kexec_file_unload(kexec_file_flags);
> - else
> + if ((result == -ENOSYS) && do_kexec_fallback)
> + do_kexec_file_syscall = 0;
> + }
> + if (!do_kexec_file_syscall)
> result = k_unload(kexec_flags);
> }
> if (do_load && (result == 0)) {
> - if (do_kexec_file_syscall)
> + if (do_kexec_file_syscall) {
> result = do_kexec_file_load(fileind, argc, argv,
> kexec_file_flags);
> - else
> + if (do_kexec_fallback) switch (result) {
> + /*
> + * Something failed with signature verification.
> + * Reject the image.
> + */
> + case -ELIBBAD:
> + case -EKEYREJECTED:
> + case -ENOPKG:
> + case -ENOKEY:
> + case -EBADMSG:
> + case -EMSGSIZE:
> + /*
> + * By default reject or do nothing if
> + * succeded
> + */
> + default: break;
> + case -ENOSYS: /* not implemented */
> + /*
> + * Parsing image or other options failed
> + * The image may be invalid or image
> + * type may not supported by kernel so
> + * retry parsing in kexec-tools.
> + */
> + case -EINVAL:
> + case -ENOEXEC:
> + /*
> + * ENOTSUPP can be unsupported image
> + * type or unsupported PE signature
> + * wrapper type, duh
> + */
> + case -ENOTSUP:
> + do_kexec_file_syscall = 0;
> + break;
It looks to me it is enough only checking -ENOSYS maybe also -ENOTSUPP and
then set do_kexec_file_syscall = 0;
EINVAL and ENOEXEC are real errors, I do not understand why still
fallback. Also thos signature verification errors are not needed
in this code as well.
> + }
> + }
> + if (!do_kexec_file_syscall)
> result = my_load(type, fileind, argc, argv,
> kexec_flags, entry);
> }
> diff --git a/kexec/kexec.h b/kexec/kexec.h
> index 9fd0355eacd0..d445fbe3e486 100644
> --- a/kexec/kexec.h
> +++ b/kexec/kexec.h
> @@ -220,6 +220,7 @@ extern int file_types;
> #define OPT_PANIC 'p'
> #define OPT_KEXEC_FILE_SYSCALL 's'
> #define OPT_KEXEC_SYSCALL 'c'
> +#define OPT_KEXEC_SYSCALL_AUTO 'a'
> #define OPT_STATUS 'S'
> #define OPT_MEM_MIN 256
> #define OPT_MEM_MAX 257
> @@ -248,11 +249,12 @@ extern int file_types;
> { "reuseinitrd", 0, 0, OPT_REUSE_INITRD }, \
> { "kexec-file-syscall", 0, 0, OPT_KEXEC_FILE_SYSCALL }, \
> { "kexec-syscall", 0, 0, OPT_KEXEC_SYSCALL }, \
> + { "kexec-syscall-auto", 0, 0, OPT_KEXEC_SYSCALL_AUTO }, \
> { "debug", 0, 0, OPT_DEBUG }, \
> { "status", 0, 0, OPT_STATUS }, \
> { "print-ckr-size", 0, 0, OPT_PRINT_CKR_SIZE }, \
>
> -#define KEXEC_OPT_STR "h?vdfxyluet:pscS"
> +#define KEXEC_OPT_STR "h?vdfxyluet:pscaS"
>
> extern void dbgprint_mem_range(const char *prefix, struct memory_range *mr, int nr_mr);
> extern void die(const char *fmt, ...)
> --
> 2.13.6
>
>
> _______________________________________________
> kexec mailing list
> kexec@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/kexec
Thanks
Dave
_______________________________________________
kexec mailing list
kexec@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/kexec
