Re: [PATCH v2 2/2] kexec-tools: Make xc_dlhandle static

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 01/24/2018 02:36 AM, Simon Horman wrote:
On Tue, Jan 23, 2018 at 09:59:14PM +0100, Daniel Kiper wrote:
On Tue, Jan 23, 2018 at 01:12:51PM -0600, Eric DeVolder wrote:
This patch is a follow-on to commit 43d3932e "kexec-tools: Perform
run-time linking of libxenctrl.so". This patch addresses feedback
from Daniel Kiper.

This patch implements Daniel's suggestion to make the
xc_dlhandle variable static.

Signed-off-by: Eric DeVolder <eric.devolder@xxxxxxxxxx>

Just two nitpicks... Otherwise you can add

Reviewed-by: Daniel Kiper <daniel.kiper@xxxxxxxxxx>

Eric, please address Daniel's review and repost this patch as appropriate.
There is no need to repost patch 1/2 as I've applied it.


Simon, I've incorporated Daniel's feedback and posted v3 of this patch.
Regards,
eric

_______________________________________________
kexec mailing list
kexec@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/kexec



[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux