Simon,
Thank you! I've a request below.
Eric
On 01/18/2018 01:53 AM, Simon Horman wrote:
On Wed, Jan 17, 2018 at 10:39:01AM -0600, Eric DeVolder wrote:
When kexec is utilized in a Xen environment, it has an explicit
run-time dependency on libxenctrl.so. This dependency occurs
during the configure stage and when building kexec-tools.
...
Thanks for addressing this and thanks doubly for the very comprehensive
changelog.
Applied.
In the commit message, I show this post-patch results table:
The results were:
Scenario | Xen environment | non-Xen environment
1 | fail - see Note 5 | pass
2 | fail - see Note 5 | pass
3 | fail - see Note 6 | pass
4 | pass | pass
5 | fail - see Note 6 | pass
6 | pass | pass
There is an error here in what I reported, the table should in fact
report a fail for scenario 4 in the non-Xen environment.
If it isn't too late, I think it would be worthwhile to reword
the commit message for these corrections:
238c238
< 4 | pass | pass
---
> 4 | pass | fail - see Note 7
249a250,254
> Note 7: This kexec has the explicit dependency on libxenctrl.so
> which prevents it from running in a non-Xen environment. This is
> expected as this is the original issue for which this patch is
> intended to address.
>
253c258
< libxenctrl.so, all six scenarios are expected to "pass" in a
---
> libxenctrl.so, all but scenario 4 are expected to "pass" in a
Regards,
Eric
_______________________________________________
kexec mailing list
kexec@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/kexec
