On Wednesday 24 May 2017 11:13 AM, Pratyush Anand wrote: > Hi Hatayama, > > > On Wednesday 24 May 2017 07:39 AM, Hatayama, Daisuke wrote: >> How about this? >> - return immediately in case of kaslr because there's no need to refer to >> PT_LOAD entries, >> - refer to PT_LOAD entries only if they exist, and >> - finally try to get page offset according to kernel versions. > > It looks fine to me. > So if you agree then I can send next revision with your "Suggested-by" tag. > > https://github.com/pratyushanand/makedumpfile/commit/16655ce1f4c2da8d4066072db2a03c84bf2553fe return TRUEin case of KASLR success was missing in above. Fixed that. https://github.com/pratyushanand/makedumpfile/commit/e13807fc6391bf71e7822d39cdb084d3bf481818 ~Pratyush
