On 05/17/17 at 07:51am, Eric DeVolder wrote: > > > diff --git a/kexec/firmware_memmap.c b/kexec/firmware_memmap.c > > > index 4d84f00..1ee214a 100644 > > > --- a/kexec/firmware_memmap.c > > > +++ b/kexec/firmware_memmap.c > > > @@ -164,6 +164,10 @@ static int parse_memmap_entry(const char *entry, struct memory_range *range) > > > range->type = RANGE_RESERVED; > > > else if (strcmp(type, "reserved") == 0) > > > range->type = RANGE_RESERVED; > > > + else if (strcmp(type, "Reserved") == 0) > > > + range->type = RANGE_RESERVED; > > > + else if (strcmp(type, "Unknown E820 type") == 0) > > > + range->type = RANGE_RESERVED; > > > > Should we change the "reserved" one to "Reserved" so that we don't need > > to have "reserved" and "Reserved" at the same time? > > The lower-case "reserved" has been in use by the kernel for quite a long > while, and upper-case "Reserved" has been recently introduced. I think > removing lower-case "reserved" would result in problems with existing, > older, kernels that still would be using "reserved". Thanks. Then it looks good to me. Ack. Simon might pick several patches one time every several days. Please wait. > > > > > > else if (strcmp(type, "ACPI Non-volatile Storage") == 0) > > > range->type = RANGE_ACPI_NVS; > > > else if (strcmp(type, "Uncached RAM") == 0) > > > -- > > > 2.7.4 > > > > > > > > > _______________________________________________ > > > kexec mailing list > > > kexec at lists.infradead.org > > > http://lists.infradead.org/mailman/listinfo/kexec > > _______________________________________________ > kexec mailing list > kexec at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/kexec
