Hi James, On Wednesday 18 January 2017 01:13 PM, Pratyush Anand wrote: > >> >>> + * in kexec >>> + */ >>> + if (next_tbl_cnt > 5) >>> + die("%s: No more memory for page table\n", __func__); >> >> die()? With a bit of juggling can't we return an error so we never try >> to enable >> the MMU+dcache instead? >> > > OK. can do that. It does not seem easy to do that. We will have to revert job of add_buffer_phys_virt() in case of failure, and it will need lot of new code. So, IMHO it would be better to keep die() as of now. What do you say? ~Pratyush