Two nitpicks below...
On Fri, Feb 10, 2017 at 04:07:33PM -0600, Eric DeVolder wrote:
> Implement get_crash_kernel_load_range() in support of
> print crash kernel region size option.
This contradicts what is provided in patch body. You should rather say here
that you provide a stub to fulfill requirements of subsequent patch(es).
> Signed-off-by: Eric DeVolder <eric.devolder at oracle.com>
> ---
> kexec/arch/arm64/crashdump-arm64.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/kexec/arch/arm64/crashdump-arm64.c b/kexec/arch/arm64/crashdump-arm64.c
> index d2272c8..b0e4713 100644
> --- a/kexec/arch/arm64/crashdump-arm64.c
> +++ b/kexec/arch/arm64/crashdump-arm64.c
> @@ -19,3 +19,9 @@ int is_crashkernel_mem_reserved(void)
> {
> return 0;
> }
> +
> +int get_crash_kernel_load_range(uint64_t *start, uint64_t *end)
> +{
> + /* Crash kernel region size is not exposed by the system */
Usually I add a full stop at the end of comment. Just my preference.
Otherwise:
Reviewed-by: Daniel Kiper <daniel.kiper at oracle.com>
Daniel
