On Thu, Feb 02, 2017 at 12:08:50PM +0000, Mark Rutland wrote: > On Thu, Feb 02, 2017 at 12:03:20PM +0000, Mark Rutland wrote: > > On Thu, Feb 02, 2017 at 03:24:09PM +0900, AKASHI Takahiro wrote: > > > On Wed, Feb 01, 2017 at 07:21:22PM +0000, Mark Rutland wrote: > > > > On Wed, Feb 01, 2017 at 09:46:28PM +0900, AKASHI Takahiro wrote: > > > > > > +/* > > > > > + * reserve_elfcorehdr() - reserves memory for elf core header > > > > > + * > > > > > + * This function reserves elf core header given in "elfcorehdr=" kernel > > > > > + * command line parameter. This region contains all the information about > > > > > + * primary kernel's core image and is used by a dump capture kernel to > > > > > + * access the system memory on primary kernel. > > > > > + */ > > > Can you also fix the comment above reserve_elfcorehdr()? It refers to a > > non-existent kernel command line option. > > ... or rather, one that's handled by core code, not > reserve_elfcorehdr(). > > So more specifically, it would be nicer to have something like: > > /* > * reserve_elfcorehdr() - reserves memory for elf core header > * > * This function reserves the memory occupied by an elf core header > * described in the device tree. This region contains all the > * information about primary kernel's core image and is used by a dump > * capture kernel to access the system memory on primary kernel. > */ Perfect! Thanks a lot, -Takahiro AKASHI > Thanks, > Mark.
