On Fri, Apr 07, 2017 at 09:57:44PM +0200, Daniel Kiper wrote: > On Fri, Apr 07, 2017 at 09:13:06AM -0500, Eric DeVolder wrote: > > Commit 2cf7cb9a "kexec: implemented XEN KEXEC STATUS to determine > > if an image is loaded" added configure-time detection of the > > kexec_status() call, but in doing so had the unintended side > > effect of disabling support for Xen altogether due to the > > missing HAVE_LIBXENCTRL=1. This corrects the broken behavior > > while still maintaining the original intention of detecting > > support for kexec_status() call. > > In general Reviewed-by: Daniel Kiper <daniel.kiper at oracle.com> > but two nitpicks. > > You do not need v0 in subject if you post first patch. Plain > "[PATCH]" (of course without quotes) is sufficient. > > > --- > > Broken behavior (HAVE_LIBXENCTRL is missing altogether): > > ... > > checking xenctrl.h usability... yes > > checking xenctrl.h presence... yes > > checking for xenctrl.h... yes > > checking for xc_kexec_load in -lxenctrl... yes > > checking for xc_kexec_status in -lxenctrl... yes > > > > in include/config.h: > > /* The kexec_status call is available */ > > #define HAVE_KEXEC_CMD_STATUS 1 > > > > Fixed behaviour (restores HAVE_LIBXENCTRL): > > ... > > checking xenctrl.h usability... yes > > checking xenctrl.h presence... yes > > checking for xenctrl.h... yes > > checking for xc_kexec_load in -lxenctrl... yes > > checking for xc_kexec_status in -lxenctrl... yes > > > > in include/config.h: > > /* The kexec_status call is available */ > > #define HAVE_KEXEC_CMD_STATUS 1 > > /* Define to 1 if you have the `xenctrl' library (-lxenctrl). */ > > #define HAVE_LIBXENCTRL 1 > > > > Reported-and-Tested-by: Konrad Rzeszutek Wilk <konrad.wilk at oracle.com> > > Signed-off-by: Eric DeVolder <eric.devolder at oracle.com> > > Reported-and-Tested-by, Signed-off-by et consortes should be just > before first "---". Otherwise "git am" will drop all of them. Thanks, I have applied this with the tags above. Eric, please consider following Daniels advice for future postings.
