Hello Martin,
>The boolean expression replicates the logic of open_dump_bitmap().
>It's simpler and less error-prone to simply check if fd_bitmap is
>valid.
>
>(I forgot to apply the very change that Petr had asked for in V2 of
>this patch. I'm very sorry. Please apply V3).
This version looks good, so could you add your Signed-off-by ?
Thanks,
Atsushi Kumagai
>---
> makedumpfile.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/makedumpfile.c b/makedumpfile.c
>index 30e1fa8..0f5be7f 100644
>--- a/makedumpfile.c
>+++ b/makedumpfile.c
>@@ -8615,8 +8615,7 @@ close_dump_file(void)
> void
> close_dump_bitmap(void)
> {
>- if (!info->working_dir && !info->flag_reassemble && !info->flag_refiltering
>- && !info->flag_sadump && !info->flag_mem_usage)
>+ if (info->fd_bitmap < 0)
> return;
>
> if (close(info->fd_bitmap) < 0)
>--
>2.9.3
