On 10/04/16 at 01:40am, Atsushi Kumagai wrote:
> >> > /*
> >> > * On linux-2.6.26, MAX_PHYSMEM_BITS is changed to 44 from 40.
> >> >@@ -159,22 +160,13 @@ get_versiondep_info_x86_64(void)
> >> > else
> >> > info->max_physmem_bits = _MAX_PHYSMEM_BITS_2_6_31;
> >> >
> >> >- if (info->kernel_version < KERNEL_VERSION(2, 6, 27))
> >> >- info->page_offset = __PAGE_OFFSET_ORIG;
> >> >- else
> >> >- info->page_offset = __PAGE_OFFSET_2_6_27;
> >> >+ info->page_offset = NUMBER(page_offset);
> >> >
> >> >- if (info->kernel_version < KERNEL_VERSION(2, 6, 31)) {
> >> >- info->vmalloc_start = VMALLOC_START_ORIG;
> >> >- info->vmalloc_end = VMALLOC_END_ORIG;
> >> >- info->vmemmap_start = VMEMMAP_START_ORIG;
> >> >- info->vmemmap_end = VMEMMAP_END_ORIG;
> >> >- } else {
> >> >- info->vmalloc_start = VMALLOC_START_2_6_31;
> >> >- info->vmalloc_end = VMALLOC_END_2_6_31;
> >> >- info->vmemmap_start = VMEMMAP_START_2_6_31;
> >> >- info->vmemmap_end = VMEMMAP_END_2_6_31;
> >> >- }
> >>
> >> These *_END_* are no longer used, it's better to remove the definitions
> >> of them.
> >
> >
> >Seems is_vmalloc_addr_x86_64 still needs VMALLOC_END and VMEMMAP_END to
> >make a judgement.
>
> Yes, VMALLOC_END and VMEMMAP_END are necessary, but what I mentioned were
> VMALLOC_END_ORIG, VMEMMAP_END_ORIG , VMALLOC_END_2_6_31 and VMEMMAP_END_2_6_31.
> The symbols were used only to initialize info->vmalloc_end and info->vmemmap_end,
> so they will be unnecessary by this patch.
Yes, you are right. These unused MACRO definitions need be removed.
Thanks for your reviewing.
Thanks
Baoquan
