On 11/08/16 at 09:26am, Dave Anderson wrote: > > > ----- Original Message ----- > > The old MODULES_VADDR need be decided by KERNEL_IMAGE_SIZE when kaslr > > enabled. Now MODULES_VADDR is not needed any more since Pratyush makes > > all VA to PA converting done by page table lookup. So remove its related > > code. > > Hi Bao, > > I'm not clear on this. The crash utility still reads/needs KERNEL_IMAGE_SIZE > from the dumpfile's vmcoreinfo data. Is it being written to the vmcoreinfo > section somewhere else in the code? Aha, seems makedumpfile will get the vmcoreinfo offset and size, then write the whole vmcoreinfo block into dumped vmcore header. But if specify '-g' for makedumpfile to only generate a vmcoreinfo file, it won't contain KERNEL_IMAGE_SIZE. makedumpfile -g vmcoreinfo -x vmlinux So I am not sure if you care about vmcoreinfo file, but you are right, I should not remove the vmcoreinfo reading and writing data. Thanks for pointing it out, will send v2 post. Thanks Baoquan
