On 06/30/16 at 01:08pm, Thiago Jung Bauermann wrote: > Am Donnerstag, 30 Juni 2016, 11:41:19 schrieb Dave Young: > > On 06/29/16 at 06:09pm, Thiago Jung Bauermann wrote: > > > Am Mittwoch, 29 Juni 2016, 15:45:18 schrieb Dave Young: > > > > On 06/28/16 at 07:18pm, Thiago Jung Bauermann wrote: > > > > > Am Dienstag, 28 Juni 2016, 15:20:55 schrieb Dave Young: > > > > > > On 06/27/16 at 04:21pm, Dave Young wrote: > > > > It looks good except one nitpick inline.. > > > > > > > > > +/** > > > > > + * kexec_locate_mem_hole - find free memory to load segment or use > > > > > in > > > > > purgatory > > > > > > > > It is not necessary to use only for purgatory load.. > > > > > > Ok, what about this? > > > > > > /** > > > > > > * kexec_locate_mem_hole - find free memory in a given kimage. > > > > Hmm, a given kimage sounds not correct, I can not get a better way to > > describe it. How about below with a little change to your previous one: > > > > kexec_locate_mem_hole - find a free chunk of memory to load kexec segment. > > In powerpc the memory chunk can also be used for the purgatory stack. > > That describes what the memory currently is used for. If powerpc or any > other architecture starts to use the memory for something else, this comment > would need to be updated. :-) > > What the function really does is find free memory in the physical address > space after the currently running kernel hands over control to whatever runs > next. What that memory is used for is decided by the caller of the function. > > Since (at least for now), the only things that run next are the purgatory > and the next kernel, what about this? > > kexec_locate_mem_hole - find free memory for the purgatory or the next > kernel Ok, I'm fine with above version. Thanks Dave
