Am Mittwoch, 29 Juni 2016, 15:47:51 schrieb Dave Young: > On 06/28/16 at 07:18pm, Thiago Jung Bauermann wrote: > > diff --git a/include/linux/kexec.h b/include/linux/kexec.h > > index e8acb2b43dd9..e16d845d587f 100644 > > --- a/include/linux/kexec.h > > +++ b/include/linux/kexec.h > > @@ -146,7 +146,30 @@ struct kexec_file_ops { > > > > kexec_verify_sig_t *verify_sig; > > > > #endif > > }; > > > > -#endif > > + > > +/** > > + * struct kexec_buf - parameters for finding a place for a buffer in > > memory + * @image: kexec image in which memory to search. > > + * @mem: On return will have address of the buffer in memory. > > + * @memsz: Size for the buffer in memory. > > + * @buf_align: Minimum alignment needed. > > + * @buf_min: The buffer can't be placed below this address. > > + * @buf_max: The buffer can't be placed above this address. > > + * @top_down: Allocate from top of memory. > > + */ > > +struct kexec_buf { > > + struct kimage *image; > > + unsigned long mem; > > + unsigned long memsz; > > + unsigned long buf_align; > > + unsigned long buf_min; > > + unsigned long buf_max; > > + bool top_down; > > +}; > > Rethink about the first patch, you dropped the user buffer in kexec_buf > But later your passing IMA digests buffer patchset may need use it. > > So keep it in kexec_buf should be better. I'm not following. The IMA buffer patchset doesn't use kexec_locate_mem_hole nor struct kexec_buf. > For the IMA buffer patchset I'm still reading and learning the > background, will reply them later. Thank you! []'s Thiago Jung Bauermann IBM Linux Technology Center