Hi Russell, On 16/06/2016:12:13:03 AM, Russell King - ARM Linux wrote: > On Wed, Jun 15, 2016 at 03:54:38PM -0700, Kees Cook wrote: > > On Wed, Jun 15, 2016 at 3:42 PM, Russell King - ARM Linux > > <linux at armlinux.org.uk> wrote: > > > In fact, the apparent confusion over this reinforces my belief that we > > > should _not_ give the size of the uncompressed image at all. > > > > > > The boot environment must be setup such that there is room for the > > > uncompressed image (aligned currently to 256 bytes) followed by the > > > size of the compressed image, with any appended DTBs included. > > > Anything which is located below that is likely to get trampled by > > > the decompressor. > > > > Okay, sounds reasonable to me. :) > > I should point out that this method should work for a zImage without > an appended DTB, and we have no way to update this header block for > the appended DTB case. Well, I might be missing with my limited knowledge. So, just to clarify, zImage is "compressed image + uncompressor". In some cases it might have "+DTB". So, zImage should be located atleast "aligned uncompressed size" above "kernel base" and, initrd should be placed at "kernel base" + "aligned uncompressed size" + "compressed image size" + "uncompressor size" + DTB(if any). However, I am unable to understand that why can't we have a flag in zImage header block, which tells that whether a DTB has been appended in the zImage or not? > > So, an alternative standpoint is that we supply only the uncompressed > image size. Then, the boot environment needs to understand that they > must allow for the compressed image and any appended DTB on top of that > (which it would see as one - the size of the combined image.) So, why not we can have all three information in header ie. "uncompressed image size", "compressed image size" and "DTB size" if appended flag is set. > > However, while that may sound like a good idea, we're falling into the > same trap that we've fallen into at the beginning of this thread: the > boot environment has to understand how the decompressor currently works, > and if we were to change that, this we're back to the calculation which > the boot environment is using not matching reality. Currently we are discussing between 4 times to 11 times. So, if we know *atleast* "uncompressed image size" then this heuristic variation can be minimized a lot. If we do not provide header, then may be we can provide library to the kexec-tools which will enable us to know the length of "uncompressed image" when "compressed image" is provided as input. ~Pratyush > > -- > RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ > FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up > according to speedtest.net.
