On Wed, 20 Jul 2016, bhe at redhat.com wrote: > On 07/20/16 at 03:54am, Wei, Jiangang wrote: > > > In fact, Eric and Ingo suggested that "it should be fixed in the bootup > > path of the dump kernel, not the crash kernel reboot path", which is > > convincing and reasonable. > > Well this patch doesn't do differently with Eric's original implemention > in kexec/kdump path. > By taking out clear_IO_APIC from disable_IO_APIC, the left code of > disable_IO_APIC will only do the virtual wire setting. So for > kexec/kdump path, code basically is the same as Eric's method. But for > poweroff/halt/reboot, it's enough to call clear_IO_APIC to disable > IO-APIC. You're completely ignoring what Jiangang said: "it should be fixed in the bootup path of the dump kernel, not the crash kernel reboot path" and that's the right way to do it. End of story. Thanks, tglx
