On Mon, 2016-01-04 at 13:26 +0100, Borislav Petkov wrote:
> On Mon, Jan 04, 2016 at 05:29:37PM +0800, Dave Young wrote:
> > Replied to Toshi old kernel will export the "GART" region for amd
> > cards.
> > So for old kernel and new kexec-tools we will have problem.
> >
> > I think add the GART desc for compitibility purpose is doable, no?
>
> Just read your other mails too. If I see it correctly, there's only one
> place which has "GART":
>
> $ git grep -e \"GART\"
> arch/x86/kernel/crash.c:235: walk_iomem_res("GART", IORESOURCE_MEM, 0,
> -1,
>
> So crash.c only excludes this region but the kernel doesn't create it.
> Right?
>
> So we can kill that walk_iomem_res(), as you say. Which would be even
> nicer...
Agreed. As Dave suggested in the other thread, we can simply remove the
walk_iomem_res("GART",) call in crash.c.
With this change, there will be no caller to walk_iomem_res(). Should we
remove walk_iomem_res() altogether, or keep it for now as a deprecated func
with the checkpatch check?
Thanks,
-Toshi
