On Tuesday 27 December 2016 10:52 AM, Atsushi Kumagai wrote: Hi Atsushi-San, >> This patch series creates eppic scripts a for range kernel versions >> they are compatible with. Eppic scripts directory host sample >> scripts to scrub sensitive information from the dump file generated >> using makedumpfile. >> >> The initial version of these scripts was based on Fedora 19 kernel. >> In brief, these scripts rely on hard coded kernel data structure >> member offsets. Kernel data structures are bound to change in due course >> and leading to failure when assumptions about the offsets differ. >> >> Atsushi-San suggested that, it's better to have different version of >> eppic scripts, those will be valid for the range of kernel release and >> their naming convention hinting, of the release they are valid across. >> >> The first patch renames the existing eppic script to reflect the kernel >> release they are compatible with. Following the format: >> <eppic_script>-<valid from kernel version>_to_<valid until kernel version>.c >> >> Rest of three patches creates new eppic scripts to match with the kernel >> data structures they work with. > Thank you for reflecting my comments, looks good to me. > v1.6.1 is ready now, these patches will be merged into v1.6.2. Thank you for the reviews and picking them. Happy New Year. -- cheers, Kamalesh.
