The boolean expression replicates the logic of open_dump_bitmap(). It's simpler and less error-prone to simply check if fd_bitmap is valid. Signed-off-by: Martin Wilck <mwilck at suse.de> --- makedumpfile.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/makedumpfile.c b/makedumpfile.c index 43278f1..771ab7c 100644 --- a/makedumpfile.c +++ b/makedumpfile.c @@ -8579,8 +8579,7 @@ close_dump_file(void) void close_dump_bitmap(void) { - if (!info->working_dir && !info->flag_reassemble && !info->flag_refiltering - && !info->flag_sadump && !info->flag_mem_usage) + if (!info->fd_bitmap) return; if ((info->fd_bitmap = close(info->fd_bitmap)) < 0) -- 2.9.2