On Fri, Sep 25, 2015 at 10:37:51AM +0800, Dave Young wrote: > While readng crash note, count_cpu variable will be never decreased in case > any failure to read the sysfs file. > > The issue was found during I test CONFIG_KEXEC_FILE only kernel option. > crash_notes are exported to sysfs only for CONFIG_KEXEC. In latest kernel > we can configure kernel with CONFIG_KEXEC_FILE only in Kconfig. In this > case, if you run a kernel with kexec_file only but do not specify "-s" > in kexec-tools arguments, then kexec-tools will hang there. > > Though "-s" is mandatory for kexec_file_load, kexec should still fail out > instead of hanging. > > Fixing the problem by always decreasing count_cpu in the for loop. > > Signed-off-by: Dave Young <dyoung at redhat.com> Thanks Dave, applied.