On Wed, 2015-10-28 at 15:06 +0800, Dave Young wrote: > Please use /* */ style comment, also it is not a bug because > In theroy it is ok for only showing later dmesg after dmesg -c in > current code. > But crash utils and vmcore-dmesg in new log buf format support > dumping all > kernel messages which includes the part before dmesg -c. It is not > harm to > keep same behavior with them. > > So the comment should be changed to something like below: > /* > * To collect full dmesg including the part before `dmesg -c` is > useful for > * later debugging. Use same logic as what crash utility is using. > */ OK, I'll update the comment and send again.
