[PATCH] Revert "kexec: use mmap instead of read for slurp_file()"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi, Michael

On 10/23/15 at 05:09pm, Michael Holzheu wrote:
> On Fri, 23 Oct 2015 11:10:00 +0800
> Dave Young <dyoung at redhat.com> wrote:
> 
> > This reverts commit 7ab842d8a004f6cd75a9d7b3528e4a70819ce4ef.
> > 
> > using mmap by default in slurp_file cause segment fault while later
> > reallocing dtb_buf during my arm kexec test.
> 
> Sorry, I obviously missed that part.
> 
> How can we fix that:
> 
> - Create a separate function slurp_file_mmap() that is called by s390x?
> - Rework xmalloc/xrealloc to always use mmap() and mremap()?
> - ...

IMHO adding a slurp_file_mmap for s390x use is a better way since the
huge initramfs is not a general case.

Thanks
Dave



[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux