On Tue 28-07-15 11:02:11, Hidehiro Kawai wrote: [...] > > Something like > [...] > > +void nmi_panic(const char *fmt, ...) > > Since we can't directly pass variable arguments to a subroutine, Sure, I was just too lazy to finish this as it was just an illustration of the idea. > we have to use a macro or do like this: > > void nmi_panic(const char *msg) > { > ... > panic("%s", msg); > } > > If there is no objection, I'm going to use a macro. Your other patch needs panic_cpu externally visible so the macro should be OK. -- Michal Hocko SUSE Labs