On Sat, Jun 06, 2015 at 02:14:12PM +0800, Minfei Huang wrote: > From: Minfei Huang <mnfhuang at gmail.com> > > Transforming PFN(Page Frame Number) to struct page is never failure, so > we can simplify the code logic to do the image->control_page assignment > directly in the loop, and remove the unnecessary conditional judgement. > > Signed-off-by: Minfei Huang <mnfhuang at gmail.com> Looks good to me. Acked-by: Vivek Goyal <vgoyal at redhat.com> Thanks Vivek > --- > kernel/kexec.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/kernel/kexec.c b/kernel/kexec.c > index 7a36fdc..4589899 100644 > --- a/kernel/kexec.c > +++ b/kernel/kexec.c > @@ -796,11 +796,10 @@ static struct page *kimage_alloc_crash_control_pages(struct kimage *image, > /* If I don't overlap any segments I have found my hole! */ > if (i == image->nr_segments) { > pages = pfn_to_page(hole_start >> PAGE_SHIFT); > + image->control_page = hole_end; > break; > } > } > - if (pages) > - image->control_page = hole_end; > > return pages; > } > -- > 2.2.2