On 12/22/15 at 07:40pm, Xunlei Pang wrote: > On 12/22/2015 at 06:47 PM, Minfei Huang wrote: > > On 12/21/15 at 02:09pm, Xunlei Pang wrote: > >> diff --git a/include/linux/kexec.h b/include/linux/kexec.h > > Hi, Xunlei. > > > > Following functions will be used only in kexec_file. Please wrap them in > > CONFIG_KEXEC_FILE. > > > > int __weak arch_kexec_kernel_image_probe(struct kimage *image, void *buf, > > unsigned long buf_len); > > void * __weak arch_kexec_kernel_image_load(struct kimage *image); > > int __weak arch_kimage_file_post_load_cleanup(struct kimage *image); > > int __weak arch_kexec_kernel_verify_sig(struct kimage *image, void *buf, > > unsigned long buf_len); > > int __weak arch_kexec_apply_relocations_add(const Elf_Ehdr *ehdr, > > Elf_Shdr *sechdrs, unsigned int relsec); > > int __weak arch_kexec_apply_relocations(const Elf_Ehdr *ehdr, Elf_Shdr *sechdrs, > > unsigned int relsec); > > Thanks for the comment. > > I noticed this as well, but seems for the function declarations we don't need do this, > since they don't consume the actual space. Yeah. I think it is better to fold above code as well, since there is no side effect. > > For example, in the include/linux/timekeeping.h > /* > * RTC specific > */ > extern bool timekeeping_rtc_skipsuspend(void); > extern bool timekeeping_rtc_skipresume(void); > > extern void timekeeping_inject_sleeptime64(struct timespec64 *delta); > > also not embraced by the corresponding macros. I think it is consistent of the construction to make code more clear. Thanks Minfei
