Hi Timur, Thanks for your review. On 05/12/2015:10:34:14 AM, Timur Tabi wrote: > Pratyush Anand wrote: > >+ & (0xffffffffffffffffUL << (VA_BITS - 1)); > > Shouldn't this be ULL instead of just UL? I think on 64 bit platform, unsigned long is always 64 bit (with gcc). More over, info->page_offset is unsigned long. So, I think using UL would be in sync, no? ~Pratyush
