Hi Suzuki, On Tue, 2015-04-07 at 17:38 +0100, Suzuki K. Poulose wrote: > On 19/03/15 20:35, Geoff Levand wrote: > > +static void kexec_list_flush(unsigned long kimage_head) > > +{ > > + void *dest; > > What is the use of dest ? dest is left over from when I had a generic list walk routine. I'll remove it. > > + unsigned long *entry; > > + > > + for (entry = &kimage_head, dest = NULL; ; entry++) { > > + unsigned int flag = *entry & > > + (IND_DESTINATION | IND_INDIRECTION | IND_DONE | > > + IND_SOURCE); > You could instead do : > > flag = *entry & IND_FLAGS; Yes, now that the patch to define IND_FLAGS has been merged. -Geoff