On 09/23/14 at 10:48am, Baoquan He wrote: > On 09/23/14 at 10:40am, Baoquan He wrote: > > On 09/22/14 at 05:02pm, Michael Holzheu wrote: > > > Hello Baoquan, > > > > > > I looked into your patches and tried to add s390x support. > > > > > > My naive approach was to just enable the is_vmalloc_addr() > > > for s390x: > > > > > > --- a/makedumpfile.h > > > +++ b/makedumpfile.h > > > @@ -814,13 +814,15 @@ unsigned long long vaddr_to_paddr_ppc(un > > > #endif /* powerpc32 */ > > > > > > #ifdef __s390x__ /* s390x */ > > > +int is_vmalloc_addr_s390x(ulong vaddr); > > > int get_machdep_info_s390x(void); > > > unsigned long long vaddr_to_paddr_s390x(unsigned long vaddr); > > > #define get_phys_base() TRUE > > > #define get_machdep_info() get_machdep_info_s390x() > > Well, seems you have added the get_machdep_info_s390x(). Could you post > your complete patch? Because I didn't see it in current devel branch. Well, I am looking in the wrong. What you need to added is get_versiondep_info_s390x() as I replied in last mail. Sorry, it's not related to get_machdep_info(). > > > > #define get_versiondep_info() TRUE > > > #define vaddr_to_paddr(X) vaddr_to_paddr_s390x(X) > > > -#define is_vmalloc_addr(X) TRUE > > > +#define is_vmalloc_addr(X) is_vmalloc_addr_s390x(X) > > > #endif /* s390x */ > > > > > > #ifdef __ia64__ /* ia64 */ > > > > Hi Michael, > > > > Please alse provide a get_versiondep_info_s390x since page_offset is > > needed in set_kcore_vmcoreinfo() and other information need it too, such > > as VMALLOC_START/VMEMMAP_START/MODULES_VADDR, if you want to provide a > > is_vmalloc_addr_s390x before initial() is called. > > > > > > Thanks > > Baoquan > > > > > > _______________________________________________ > > kexec mailing list > > kexec at lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/kexec > > _______________________________________________ > kexec mailing list > kexec at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/kexec
