On Tue, 30 Sep 2014 17:02:01 +0800 Baoquan He <bhe at redhat.com> wrote: > On 09/29/14 at 03:14pm, Michael Holzheu wrote: > > Implement is_vmalloc_addr() using /proc/iommem parsing to enable the new > > makedumpfile option "--mem-usage". > > > > Signed-off-by: Michael Holzheu <holzheu at linux.vnet.ibm.com> > > > Hi Michael, > > This idea looks good to me. One question, should it be put in > arch/s390.c since this is only for s390? Then iomem_for_each_line() need > be declared in makedumpfile.h . > > If later it's needed by other arch, can be taken out to makedumpfile.c, > that should be better. Surely this is only my personal concern, if > Atsushi like to accept it, I am fine too. Hello Atsushi, What is your preference regarding this question? Michael
