On 11/24/2014 03:18 PM, Baoquan He wrote:
> On 11/06/14 at 04:49pm, Zhou Wenjian wrote:
>
>> +#define CURRENT_SPLITBLOCK_PFN_NUM (*cur_splitblock_num * splitblock->page_per_splitblock)
>> +mdf_pfn_t
>> +calculate_end_pfn_by_splitblock(mdf_pfn_t start_pfn,
>> + int *cur_splitblock_num)
>> +{
>> + if (start_pfn>= info->max_mapnr)
>> + return info->max_mapnr;
>> +
>> + mdf_pfn_t end_pfn;
>> + long long pfn_needed, offset;
>> + char *splitblock_value_offset;
>> +
>> + pfn_needed = info->num_dumpable / info->num_dumpfile;
>> + offset = *cur_splitblock_num * splitblock->entry_size;
>> + splitblock_value_offset = splitblock->table + offset;
>> + end_pfn = start_pfn;
>> +
>> + while (*cur_splitblock_num< splitblock->num&& pfn_needed> 0) {
>> + pfn_needed -= read_from_splitblock_table(splitblock_value_offset);
>> + splitblock_value_offset += splitblock->entry_size;
>> + ++*cur_splitblock_num;
>> + }
>
> Hi Wenjian,
>
> If splitblock->page_per_splitblock is 1G, and the system ram is 4G. Now
> I set 8 dumpfiles to store the splitted vmcore, say dump0...7. Then
> dump0/1/2/3 will store 1G of data, dump4/5/6/7 will be empty. So is it
> OK?
>
> Can we do anything to avoid this case or give some note to let people not
> be panikked by empty dump files?
>
> Thanks
> Baoquan
>
>
Hello Baoquan,
Actually, we have thought about it and talked at
http://lists.infradead.org/pipermail/kexec/2014-November/012880.html .
--
Thanks
Zhou Wenjian
