On 05/08/14 at 10:14am, Vivek Goyal wrote:
> On Thu, May 08, 2014 at 07:26:17PM +0800, WANG Chao wrote:
> > In commit 91f5b9c ("kdump: pass e820 reserved region to 2nd kernel via
> > e820 table or setup_data"), I made a wrong condition check.
> >
> > We should only add cmdline for a memory range if --pass-memmap-cmdline
> > and the range type isn't RANGE_RESERVED.
> >
> > Signed-off-by: WANG Chao <chaowang at redhat.com>
>
> Ok, this fixes the issue for me. Thanks.
>
> Acked-by: Vivek Goyal <vgoyal at redhat.com>
>
> BTW, on a related note, I see that we are doing GART check two times.
>
> } else if (memcmp(str, "GART\n", 5) == 0) {
> } else if (memcmp(str, "GART\n", 5) == 0) {
>
> I am not sure if it is due to your patches or not.
Right, another stupid carelessness. Already sent a fix.
