Hi, Vivek On 03/07/14 at 09:14am, Vivek Goyal wrote: > On Fri, Mar 07, 2014 at 04:10:16PM +0800, WANG Chao wrote: > > [..] > > } > > > > - specified_table_size = determine_tce_table_size((is_kdump_kernel() ? > > - saved_max_pfn : max_pfn) * PAGE_SIZE); > > + specified_table_size = determine_tce_table_size(); > > I don't think you can get rid of saved_max_pfn right away. What if > somebody is using old first kernel and new second kernel. Then old kernel > will still be using a table size which is smaller than 8M. If TCE table size is hard coded to 8M, the new 1st kernel can never be compatible with the old 2nd kernel. Because old kernel's TCE table size is depending on saved_max_pfn, which could be from 64K to 8M, not necessarily the hard coded value 8M. If we want to drop saved_max_pfn once and for all, that's a trade-off which is worth doing. Because as Muli pointed out last time, there are very few people likely running upstream kernel on calgary machine. And most of them would use the same kernel as 1st and 2nd kernel. For the very very few people who suffers from it, we can always encourage them to use the same kernel for 1st and 2nd kernel or other solutions we have. Thanks WANG Chao
