On 07/23/14 at 07:20am, Atsushi Kumagai wrote:
> >@@ -9254,6 +9314,9 @@ main(int argc, char *argv[])
> > case OPT_DUMP_DMESG:
> > info->flag_dmesg = 1;
> > break;
> >+ case OPT_MEM_USAGE:
> >+ info->flag_mem_usage = 1;
> >+ break;
> > case OPT_COMPRESS_SNAPPY:
> > info->flag_compress = DUMP_DH_COMPRESSED_SNAPPY;
> > break;
> >@@ -9394,6 +9457,18 @@ main(int argc, char *argv[])
> >
> > MSG("\n");
> > MSG("The dmesg log is saved to %s.\n", info->name_dumpfile);
> >+ } else if (info->flag_mem_usage) {
> >+ if (!check_param_for_creating_dumpfile(argc, argv)) {
> >+ MSG("Commandline parameter is invalid.\n");
> >+ MSG("Try `makedumpfile --help' for more information.\n");
> >+ goto out;
> >+ }
>
> There is no description of this feature, could you add them
> into the help message and the man page ?
Thanks for your review. Will add them.
Thanks
Baoquan
>
>
> Thanks
> Atsushi Kumagai
>
> >+
> >+ if (!show_mem_usage())
> >+ goto out;
> >+
> >+ MSG("\n");
> >+ MSG("Showing page number of memory in different use successfully.\n");
> > } else {
> > if (!check_param_for_creating_dumpfile(argc, argv)) {
> > MSG("Commandline parameter is invalid.\n");
> >diff --git a/makedumpfile.h b/makedumpfile.h
> >index 7ffa1ee..7b537c7 100644
> >--- a/makedumpfile.h
> >+++ b/makedumpfile.h
> >@@ -910,6 +910,7 @@ struct DumpInfo {
> > int flag_force; /* overwrite existing stuff */
> > int flag_exclude_xen_dom;/* exclude Domain-U from xen-kdump */
> > int flag_dmesg; /* dump the dmesg log out of the vmcore file */
> >+ int flag_mem_usage; /*show the page number of memory in different use*/
> > int flag_use_printk_log; /* did we read printk_log symbol name? */
> > int flag_nospace; /* the flag of "No space on device" error */
> > int flag_vmemmap; /* kernel supports vmemmap address space */
> >@@ -1771,6 +1772,7 @@ struct elf_prstatus {
> > #define OPT_CYCLIC_BUFFER OPT_START+11
> > #define OPT_EPPIC OPT_START+12
> > #define OPT_NON_MMAP OPT_START+13
> >+#define OPT_MEM_USAGE OPT_START+14
> >
> > /*
> > * Function Prototype.
> >--
> >1.9.3
>
> _______________________________________________
> kexec mailing list
> kexec at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
