On 07/11/14 at 10:19am, Vivek Goyal wrote:
> Hi Bao,
>
> There is no patch 0 describing what this patch series is all about and
> what it is fixing?
Sorry, I just remembered this after patches had been sent out. But much
information has been added into the main patch [patch 7/7].
Will make a cover letter in next post.
Thanks
Baoquan
>
> Thanks
> Vivek
>
> On Fri, Jul 11, 2014 at 03:15:58PM +0800, Baoquan He wrote:
> > This is a code bug. In initialize_2nd_bitmap_cyclic pfn_memhole is
> > calculated, however it's not initialized before that. If an available
> > pfn_memhole is wanted after get_num_dumpable_cyclic invocation,
> > initializing pfn_memhole in get_num_dumpable_cyclic is necessary.
> >
> > Signed-off-by: Baoquan He <bhe at redhat.com>
> > ---
> > makedumpfile.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/makedumpfile.c b/makedumpfile.c
> > index 3884aa5..760bfd1 100644
> > --- a/makedumpfile.c
> > +++ b/makedumpfile.c
> > @@ -5588,6 +5588,8 @@ get_num_dumpable_cyclic(void)
> > mdf_pfn_t pfn, num_dumpable=0;
> > struct cycle cycle = {0};
> >
> > + pfn_memhole = info->max_mapnr;
> > +
> > for_each_cycle(0, info->max_mapnr, &cycle)
> > {
> > if (!exclude_unnecessary_pages_cyclic(&cycle))
> > --
> > 1.8.4.2
