On Wed, Jan 15, 2014 at 09:54:31AM -0800, H. Peter Anvin wrote: > On 01/15/2014 09:47 AM, Vivek Goyal wrote: > > On Wed, Jan 15, 2014 at 09:26:14AM -0800, H. Peter Anvin wrote: > >> On 01/15/2014 09:05 AM, Vivek Goyal wrote: > >>> > >>> I think this is a reasonable approach to solve the issue. Use a command > >>> line to not bring up specific cpu in second kernel which can create > >>> problems. > >>> > >>> Acked-by: Vivek Goyal <vgoyal at redhat.com> > >>> > >>> hpa, I know you are not excited about this approach. If you made up your > >>> mind that this appoarch is not worth pursuing, please do suggest what > >>> would you like to see and we can give that a try. > >>> > >>> We want to solve this problem as on large memory machines saving dump can > >>> take lot of time and we want to bring up multiple cpus and speed up > >>> compression and save on dump time. > >>> > >> > >> I'm not excited about kdump's reliance on the command line, since it > >> seems to be a neverending source of trouble, simply because the command > >> line is fundamentally intended as a human interface. > > > > So in general, what are the alternatives? Either we figure out that kernel > > is booting as kdump kernel and do things differently. That seems even > > worse as what do we want in kdump kernel will change over a period of > > time. > > > > Other thing is that pass more information in bootparams. But that does > > not seem much different than command line to me. > > > > It is the commingling of semantics that is the problem. Command line > options are generally imperative, "do this". What you want in the kdump > situation, as you yourself state above, is get a description of the > current situation and let the kdump side choose the action to take. > > As a transport mechanism the command line suffers from limited size and > that you have to share it with an arbitrary amount of user-provided > options that may or may not be essential. For large amount of info like memory map, I agree that passing on command line is not a good idea. (/me taks the blame for doing that). That's why in new patches I want to move to pass new map on bootparams and pass saved_max_pfn on command line instead. This is a fresh start so we probably can ignore compatibility with older kernels for this new interface and set things right. But for smaller options, command line seems to be good that they don't consume precious space in bootparams. If we introduce an option today, we are not sure if kdump will continue to use that option down the line or not. For example, few years down the line, we might be able to send INIT IPI to boot cpu too and not need disable_cpu_apicid. Same is the case with max_cpus vs nr_cpus. We used to use max_cpus=1 and now use nr_cpus=1. If we put all this informatoin in bootparams, they might soon become obsolete and keep on sitting there for eternity with no users. Also by creating a command line, a user can use these knobs as debugging options and can easily test first kernel's behavior to make sure knob works well in first kernel before it is tested in second kernel. By making it part of bootparams, we have no idea whether knob works fine in first kernel or not. For above reasons, I am not averse to the idea of commingling. Thanks Vivek
