On 01/06/14 at 02:14pm, Vivek Goyal wrote:
> On Tue, Jan 07, 2014 at 01:37:34AM +0800, WANG Chao wrote:
> > It seems gcc doesn't check return type from inline function.
> > struct_val_u64() should return u64 otherwise upper 32bit is lost.
> >
> > Signed-off-by: WANG Chao <chaowang at redhat.com>
>
> Acked-by: Vivek Goyal <vgoyal at redhat.com>
>
> Vivek
Hi, Simon
Could you please pick up this one?
Thanks
WANG Chao
>
> > ---
> > vmcore-dmesg/vmcore-dmesg.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/vmcore-dmesg/vmcore-dmesg.c b/vmcore-dmesg/vmcore-dmesg.c
> > index 0f477c0..df14c89 100644
> > --- a/vmcore-dmesg/vmcore-dmesg.c
> > +++ b/vmcore-dmesg/vmcore-dmesg.c
> > @@ -529,7 +529,7 @@ static inline uint32_t struct_val_u32(char *ptr, unsigned int offset)
> > return(file32_to_cpu(*(uint32_t *)(ptr + offset)));
> > }
> >
> > -static inline uint32_t struct_val_u64(char *ptr, unsigned int offset)
> > +static inline uint64_t struct_val_u64(char *ptr, unsigned int offset)
> > {
> > return(file64_to_cpu(*(uint64_t *)(ptr + offset)));
> > }
> > --
> > 1.8.4.2
> >
> >
> > _______________________________________________
> > kexec mailing list
> > kexec at lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/kexec
>
> _______________________________________________
> kexec mailing list
> kexec at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
