On Tue, Feb 25, 2014 at 01:09:34PM -0800, H. Peter Anvin wrote: > On 02/25/2014 10:20 AM, Vivek Goyal wrote: > > > > Please let me know if you don't like the idea and you still think there > > should be a shared implementation between arch/x86/boot/ and > > arch/x86/purgatory/. > > > > That is what I would *prefer*. There are some other string functions in > arch/x86/boot/string.c which also ought to be sharable (and are in > places already.) > Ok, I will look into it. Possibly move optimized 32bit and 64bit version of memcpy in arch/x86/boot/string.c and include it in purgaotry files. Or we could define new C version of routines in boot/string.c and leave optimized versions where they are. Thanks Vivek