On 04/17/14 at 05:45pm, Dave Young wrote: > > > > It comes to me that in the future there are two places that can be > > improved or cleaned up. I summarize them as the followings: > > > > - clean up cmdline_add_memmap and cmdline_add_memmap_acpi > > - Dropping hard limitation memory maps, like CRASH_MAX_MEMMAP_NR > > Hmm, kernel E820MAX is 128 in case non EFI like below, likely 1024 > is enough, so keep current limitation is good: > > #ifdef CONFIG_EFI > #include <linux/numa.h> > #define E820_X_MAX (E820MAX + 3 * MAX_NUMNODES) > #else /* ! CONFIG_EFI */ > #define E820_X_MAX E820MAX > #endif That's ok. I'm also fine with hard code 1024 for now. > > > > > Do you have additional issues needed to be addressed? > > Another in mind is using one array for both 1st kernel and 2nd kernel > if possible.
