On 04/11/14 at 10:22am, Dave Young wrote: > On 04/10/14 at 05:12pm, WANG Chao wrote: > > This change will be used later: > > > > add_memmap(.., int *nr_memmap, .., int type); > > delete_memmap(.., int *nr_memmap, ..); > > > > Signed-off-by: WANG Chao <chaowang at redhat.com> > > --- > > kexec/arch/i386/crashdump-x86.c | 22 +++++++++++++--------- > > 1 file changed, 13 insertions(+), 9 deletions(-) > > > > diff --git a/kexec/arch/i386/crashdump-x86.c b/kexec/arch/i386/crashdump-x86.c > > index 72bce0b..e695eaf 100644 > > --- a/kexec/arch/i386/crashdump-x86.c > > +++ b/kexec/arch/i386/crashdump-x86.c > > @@ -476,8 +476,8 @@ static int exclude_region(int *nr_ranges, uint64_t start, uint64_t end) > > > > /* Adds a segment from list of memory regions which new kernel can use to > > * boot. Segment start and end should be aligned to 1K boundary. */ > > -static int add_memmap(struct memory_range *memmap_p, unsigned long long addr, > > - size_t size) > > +static int add_memmap(struct memory_range *memmap_p, int *nr_memmap_p, > > + unsigned long long addr, size_t size, int type) > > Maybe nr_memmap is better than nr_memmap_p? Sure. Will rename. I thought nr_memmap_p vs. memmap_p looked more no-brainer.
