From: Atsushi Kumagai <kumagai-atsushi@xxxxxxxxxxxxxxxxx> Subject: RE: [PATCH v2 2/3] Generic handling of multi-page exclusions Date: Tue, 8 Apr 2014 09:00:19 +0000 > > At that time, I chose the current code since it was simpler and safer. > http://www.mail-archive.com/kexec%40lists.infradead.org/msg10207.html > > Don't you like this ? > Sorry. I had forgotten this. We should keep the sanity check there. But in our policy, we should not pass to set_bitmap_cyclic(), pfn and cycle where pfn is not in the cycle. We should chceck that in the caller side and pass pfn in the cycle only. Also, on the current implementation, even if pfn outside a current cycle is passed to set_bitmap_cyclic(), we don't have any means to know that. So, how about warning that only once at runtime? Thanks. HATAYAMA, Daisuke