(2013/09/11 16:51), Atsushi Kumagai wrote: > Hello HATAYAMA-san, > > (2012/11/16 14:02), HATAYAMA Daisuke wrote: >> Clearling bits on cyclic buffer can overrun the cyclic buffer >> according to some combination of MAX_ORDER and cyclic buffer size. >> >> The cyclic buffer size is corrected if possible. >> >> Signed-off-by: HATAYAMA Daisuke <d.hatayama at jp.fujitsu.com> > > I know it's so late, I found that updating pfn_cyclic is missing. > It can cause memory corruption. > Hello Kumagai-san, Reviewed-by: HATAYAMA Daisuke <d.hatayama at jp.fujitsu.com> It might be even better to introduce some kind of helper function that sets up these cyclic-mode-related parameters and then to use it in initial() and check_cyclic_buffer_overrun(). -- Thanks. HATAYAMA, Daisuke
