(2013/10/30 19:52), Atsushi Kumagai wrote: > (2013/10/24 15:52), HATAYAMA Daisuke wrote: >> Currently, 1st bitmap is created during cyclic process, but the >> information represented by the 1st bitmap, originally present memory, >> is still available from ELF program header table, so we don't need to >> keep the 1st bitmap even in cyclic process. >> >> Supported is a conversion from ELF to kdump-compressed format only, >> not from ELF to ELF. >> >> Signed-off-by: HATAYAMA Daisuke <d.hatayama at jp.fujitsu.com> >> --- >> makedumpfile.c | 224 +++++++++++++++++++++++++++++++++++++++++++++++++++----- >> 1 file changed, 202 insertions(+), 22 deletions(-) >> >> diff --git a/makedumpfile.c b/makedumpfile.c >> index 4b6c0ed..7440c97 100644 >> --- a/makedumpfile.c >> +++ b/makedumpfile.c >> @@ -3055,7 +3055,8 @@ out: >> * bufsize_cyclic is used to allocate 1st and 2nd bitmap, >> * so it should be truncated to the half of free_memory. >> */ >> - info->bufsize_cyclic = free_memory / 2; >> + if (info->flag_elf_dumpfile) >> + info->bufsize_cyclic = free_memory / 2; >> } >> } > > I think here should be changed like below: > > if (info->flag_elf_dumpfile) > info->bufsize_cyclic = free_memory / 2; > else > info->bufsize_cyclic = free_memory; > Thanks. I'll fix this. -- Thanks. HATAYAMA, Daisuke
