On Tue, Oct 15, 2013 at 7:48 AM, Vivek Goyal <vgoyal at redhat.com> wrote: > On Mon, Oct 14, 2013 at 11:54:22AM -0700, Yinghai Lu wrote: >> On Mon, Oct 14, 2013 at 4:46 AM, WANG Chao <chaowang at redhat.com> wrote: >> User should change crashkernel=X to crashkernel=X,high. > > I think if we can extend old syntax of crashkernel=X, then it makes life > really easy for users. > >> >> As user could forget to update kexec-tools to utilize ",high" feature, and get >> kdump later fail later. > > Previously high reservation (reservation above 896M) will anyway fail. So > instead of failing, if we try reservation in higher memory areas why that > would break old kexec-tools? If thel old kexec-tools would fail, we should let them fail early as possible, do not reserve at first point. > > IOW, previously anyway kexec-tools will not work as no memory will be > reserved in higher memory area. Now memory will be reserved but old > kexec-tools should fail as it can't load in that area. > > If that works, then one would use crashkernel=X,high only if he is > particualr that memory reservation comes from area above 4G (despite > the fact that same memory could have been reserved below 4G too). My point: Push user to use ",high" as more as possible, so we only to handle one path eventually. for old kernel, leave them to use old grammer. do not need to change it. Also boot loader should always have different entry for old kernel and new kernel. Thanks Yinghai
