Hello simon,
On 10/16/2013 03:12 PM, Simon Horman wrote:
> On Thu, Sep 05, 2013 at 05:21:21PM +0800, WANG Chao wrote:
>> People are not always aware of PACKED macro and tend to
>> __attribute__((packed)) more directly. So let's remove PACKED to unify
>> things.
>>
>> Signed-off-by: WANG Chao <chaowang at redhat.com>
>
> Thanks, this looks good to me.
>
> Reviewed-by: Simon Horman <horms at verge.net.au>
>
> I suggest re-posting with Andre Morton CCed to see
> if he will pick it up.
You should take this because this is a change in kexec-tools,
not in kernel source......:)
>
>> ---
>> include/x86/x86-linux.h | 6 ++----
>> 1 file changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/include/x86/x86-linux.h b/include/x86/x86-linux.h
>> index 0949dc2..c41e5f2 100644
>> --- a/include/x86/x86-linux.h
>> +++ b/include/x86/x86-linux.h
>> @@ -12,8 +12,6 @@
>>
>> #ifndef ASSEMBLY
>>
>> -#define PACKED __attribute__((packed))
>> -
>> #ifndef E820_RAM
>> struct e820entry {
>> uint64_t addr; /* start of memory segment */
>> @@ -23,7 +21,7 @@ struct e820entry {
>> #define E820_RESERVED 2
>> #define E820_ACPI 3 /* usable as RAM once ACPI tables have been read */
>> #define E820_NVS 4
>> -} PACKED;
>> +} __attribute__((packed));
>> #endif
>>
>> /* FIXME expand on drive_info_)struct... */
>> @@ -255,7 +253,7 @@ struct x86_linux_header {
>> uint64_t pref_address; /* 0x258 */
>> uint32_t init_size; /* 0x260 */
>> uint32_t handover_offset; /* 0x264 */
>> -} PACKED;
>> +} __attribute__((packed));
>>
>> #endif /* ASSEMBLY */
>>
>> --
>> 1.8.3.1
>>
>>
>> _______________________________________________
>> kexec mailing list
>> kexec at lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/kexec
>>
>
--
Thanks.
Zhang Yanfei
