When use "--message-level 31" to do a kdump compressed dump, printing
message is not correct any more. Free pages number is doubled as below.
Original pages : 0x000000000007539c
Excluded pages : 0x00000000000d986a
Pages filled with zero : 0x0000000000001196
Cache pages : 0x0000000000025008
Cache pages + private : 0x0000000000004baa
User process data pages : 0x00000000000127d0
Free pages : 0x000000000009c352
Hwpoison pages : 0x0000000000000000
Remaining pages : 0xfffffffffff9bb32
(The number of pages is reduced to 38418230895101%.)
Memory Hole : 0x000000000000ac62
--------------------------------------------------
Total pages : 0x000000000007fffe
After review code, it's caused by update_cyclic_region. This function calls
exclude_unnecessary_pages_cyclic to set partial_bitmap2, then free pages are
counted. But when write the 1st bitmap, it's also called though it is
useless, and pfn_free add free pages number. Here add a new function
update_cyclic_region_without_exclude which is used to set partial_bitmap1
specifically.
---
makedumpfile.c | 22 +++++++++++++++++++++-
1 file changed, 21 insertions(+), 1 deletion(-)
diff --git a/makedumpfile.c b/makedumpfile.c
index 3746cf6..367e8cf 100644
--- a/makedumpfile.c
+++ b/makedumpfile.c
@@ -4745,6 +4745,26 @@ update_cyclic_region(unsigned long long pfn)
return TRUE;
}
+
+int
+update_cyclic_region_without_exclude(unsigned long long pfn)
+{
+ if (is_cyclic_region(pfn))
+ return TRUE;
+
+ info->cyclic_start_pfn = round(pfn, info->pfn_cyclic);
+ info->cyclic_end_pfn = info->cyclic_start_pfn + info->pfn_cyclic;
+
+ if (info->cyclic_end_pfn > info->max_mapnr)
+ info->cyclic_end_pfn = info->max_mapnr;
+
+ if (info->flag_elf_dumpfile && !create_1st_bitmap_cyclic())
+ return FALSE;
+
+ return TRUE;
+}
+
+
int
copy_bitmap(void)
{
@@ -6805,7 +6825,7 @@ write_kdump_pages_and_bitmap_cyclic(struct cache_data *cd_header, struct cache_d
for (pfn = 0; pfn < info->max_mapnr; pfn++) {
if (is_cyclic_region(pfn))
continue;
- if (!update_cyclic_region(pfn))
+ if (!update_cyclic_region_without_exclude(pfn))
return FALSE;
if (!create_1st_bitmap_cyclic())
return FALSE;
--
1.8.3.1
