? 2013?03?14? 17:09, Simon Horman ??: > On Thu, Mar 14, 2013 at 01:32:20AM +0800, Zhang Yanfei wrote: >> From: Zhang Yanfei <zhangyanfei at cn.fujitsu.com> >> >> By replacing all the explicit align opertion with marco _ALIGN*, >> the code logic could be more clear. >> >> Besides, remove the duplicate _ALIGN_* definition in file >> kexec/arch/ppc/crashdump-powerpc.h. > > This appears to break the build on ppc. > > > powerpc-linux-gnu-gcc -Wall -Wextra -Wpointer-arith -Wwrite-strings -Wformat -O2 -fomit-frame-pointer -pipe -fno-strict-aliasing -Wall -Wstrict-prototypes -I/include -I./include -I./util_lib/include -Iinclude/ -I./kexec/libfdt -I./kexec/arch/ppc/include -c -MD -o kexec/arch/ppc/fs2dt.o kexec/arch/ppc/fs2dt.c > kexec/arch/ppc/fs2dt.c: In function 'add_usable_mem_property': > kexec/arch/ppc/fs2dt.c:146: warning: comparison between signed and unsigned integer expressions > kexec/arch/ppc/fs2dt.c:128: warning: unused variable 'buf' > kexec/arch/ppc/fs2dt.c:125: warning: unused parameter 'len' > kexec/arch/ppc/fs2dt.c: In function 'putnode': > kexec/arch/ppc/fs2dt.c:326: warning: passing argument 4 of 'scandir' from incompatible pointer type > /usr/powerpc-linux-gnu/include/dirent.h:252: note: expected 'int (*)(const struct dirent **, const struct dirent **)' but argument is of type 'int (*)(const void *, const void *)' > kexec/arch/ppc/fs2dt.c:449:1: error: unterminated argument list invoking macro "_ALIGN" > kexec/arch/ppc/fs2dt.c: In function 'create_flatten_tree': > kexec/arch/ppc/fs2dt.c:410: error: '_ALIGN' undeclared (first use in this function) > kexec/arch/ppc/fs2dt.c:410: error: (Each undeclared identifier is reported only once > kexec/arch/ppc/fs2dt.c:410: error: for each function it appears in.) > kexec/arch/ppc/fs2dt.c:410: error: expected ';' at end of input > kexec/arch/ppc/fs2dt.c:410: error: expected declaration or statement at end of input > kexec/arch/ppc/fs2dt.c:395: warning: unused variable 'buf' > kexec/arch/ppc/fs2dt.c:394: warning: unused variable 'tlen' > kexec/arch/ppc/fs2dt.c:390: warning: unused parameter 'info' > kexec/arch/ppc/fs2dt.c:390: warning: unused parameter 'bufp' > kexec/arch/ppc/fs2dt.c:391: warning: unused parameter 'sizep' > make: *** [kexec/arch/ppc/fs2dt.o] Error 1 > >> Sorry for my carelessness. I forgot a ")" . I've updated the patch.
