On Mon, 10 Jun 2013 22:35:30 +0900
HATAYAMA Daisuke <d.hatayama at gmail.com> wrote:
> 2013/6/8 Michael Holzheu <holzheu at linux.vnet.ibm.com>:
> <cut>
> > @@ -935,10 +967,17 @@ static int __init vmcore_init(void)
> > {
> > int rc = 0;
> >
> > - /* If elfcorehdr= has been passed in cmdline, then capture the dump.*/
> > - if (!(is_vmcore_usable()))
> > - return rc;
> > + /*
> > + * If elfcorehdr= has not been passed in cmdline, try to get the
> > + * header from 2nd kernel, then capture the dump.
> > + */
> > + if (!(is_vmcore_usable())) {
> > + rc = elfcorehdr_alloc();
> > + if (rc)
> > + return rc;
> > + }
>
> Here you removed comment in the 1st path. Please keep it.
Perhaps something like the following:
/*
* If elfcorehdr= has been passed in cmdline, then capture the dump.
* Otherwise, try to get the header from the 2nd kernel.
*/
Michael
