On Wed, Jul 03, 2013 at 03:59:33PM +0200, Michael Holzheu wrote: > On Tue, 2 Jul 2013 11:42:14 -0400 > Vivek Goyal <vgoyal at redhat.com> wrote: > > > On Mon, Jul 01, 2013 at 09:32:37PM +0200, Michael Holzheu wrote: > > [snip] > > > > This handler works as follows: > > > > > > * Get already available or new page from page cache (find_or_create_page) > > > * Check if /proc/vmcore page is filled with data (PageUptodate) > > > * If yes: > > > Return that page > > > * If no: > > > Fill page using __vmcore_read(), set PageUptodate, and return page > > > > > > Signed-off-by: Michael Holzheu <holzheu at linux.vnet.ibm.com> > > > > In general vmcore related changes look fine to me. I am not very familiar > > with the logic of finding pages in page cache and using page uptodate > > flag. > > > > Hatayama, can you please review it. > > > > Acked-by: Vivek Goyal <vgoyal at redhat.com> > > Hello Vivek, > > If Hatayama accepts the patch, should we then send the patch series to > Andrew Morton? Yes, once hatayama reviews the patch, please send it to Anderew Morton for for inclusion of paches. Thanks Vivek
