On Tue, 2013-02-26 at 13:30 +0800, Zhang Yanfei wrote: > This is just a tweak: using min_t to simplify logic of variable > assignments. > > v3: > - cast type of (PAGE_SIZE - (maddr & ~PAGE_MASK)) into size_t. Why? Isn't this just a redundant cast? > diff --git a/kernel/kexec.c b/kernel/kexec.c [] > @@ -822,13 +822,9 @@ static int kimage_load_normal_segment(struct kimage *image, [] > + mchunk = min_t(size_t, mbytes, > + (size_t)(PAGE_SIZE - (maddr & ~PAGE_MASK))); #define min_t(type, x, y) ({ \ type __min1 = (x); \ type __min2 = (y); \ __min1 < __min2 ? __min1: __min2; })